Metadata server address modification to account for default port #12468
+39
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
approved these changes
Nov 5, 2025
Member
|
/gcbrun |
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
ejona86
reviewed
Nov 10, 2025
| String host = envValue; | ||
| int portIndex = host.lastIndexOf(':'); | ||
| if (portIndex != -1) { | ||
| host = host.substring(0, portIndex); |
Member
There was a problem hiding this comment.
Overriding the port is surprising. There should be some comment or such about what is going on.
(From what I can tell, the environment variable is normally accessing port 80. But for ALTS we use a different port, so we want to ignore the port because isn't the same port as used for authentication tokens.)
Member
Contributor
Author
|
Changed the utilization of the GCE Metadata host server address environment variable so that if a port is specified or unspecified, it defaults to use port 8080 for ALTS handshake. Tested scenarios where environment variable was not set, environment variable was set but with no port, and environment variable was set with a port other than 8080 |
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
Member
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the utilization of the GCE Metadata host server address environment variable to account for the case where the user does not specify a port (defaults to port 8080)
b/451639946
cc: @apolcyn, @anicr7